Add factory #74
Closed
Add factory #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MerlinEgalite
requested review from
a team,
adhusson,
Rubilmax,
QGarchery,
MathisGD and
Jean-Grimal
and removed request for
a team
MathisGD
reviewed
Feb 18, 2024
Comment on lines
+24
to
+50
| event CreateChainlinkOracle( | ||
| address oracle, | ||
| address caller, | ||
| address baseVault, | ||
| uint256 baseVaultConversionSample, | ||
| address quoteVault, | ||
| uint256 quoteVaultConversionSample, | ||
| bytes32 salt | ||
| ); | ||
|
|
||
| /// @notice Emitted when a new Chainlink oracle is created. | ||
| /// @param oracle The address of the Chainlink oracle. | ||
| /// @param baseFeed1 First base feed. | ||
| /// @param baseFeed2 Second base feed. | ||
| /// @param quoteFeed1 First quote feed. | ||
| /// @param quoteFeed2 Second quote feed. | ||
| /// @param baseTokenDecimals Base token decimals. | ||
| /// @param quoteTokenDecimals Quote token decimals. | ||
| event CreateChainlinkOracleFeeds( | ||
| address oracle, | ||
| address baseFeed1, | ||
| address baseFeed2, | ||
| address quoteFeed1, | ||
| address quoteFeed2, | ||
| uint256 baseTokenDecimals, | ||
| uint256 quoteTokenDecimals | ||
| ); |
There was a problem hiding this comment.
I think that we can just log the address
|
replaced by #77 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
because it will save us time